code: affect optional_link in dec_rec - #725
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
| outgoing: realizes | ||
|
|
||
| # Decision Record | ||
| affects: |
There was a problem hiding this comment.
Extend the dec_rec type accordingly. I think I actually removed this one because it seemed to be unused.
There was a problem hiding this comment.
it is already added here with dec_rec in the metamodel: https://github.com/eclipse-score/docs-as-code/blob/main/src/extensions/score_metamodel/metamodel.yaml#L990
| if rst_file == "options/test_dec_rec.rst": | ||
| needs_by_id = {need["id"]: need for need in needs_view.values()} | ||
| assert needs_by_id["dec_rec__test__decision_record_1"].get("affects") == [ | ||
| "dec_rec__test__decision_record_2" | ||
| ] |
There was a problem hiding this comment.
no need to test individual links, they are verified generically. so we dont need to verify "affects" with a custom test here.
| :status: accepted | ||
| :context: A decision record is needed for the test. | ||
| :decision: Use a dedicated decision record need type. | ||
| :affects: dec_rec__test__decision_record_2 |
There was a problem hiding this comment.
nitpick: just for sanity. DR2 affects DR1, not the other way around?! 😆
|
"affects" seems like such a trivial word... but its not. People will interpret it differently. Is there any description anywhere on where we would expect people to use |
|
Documentation preview for this pull request is available at: |
3 participants
📌 Description
🚨 Impact Analysis
✅ Checklist