Remote datetime_converter - #471
Open
limdor wants to merge 1 commit into
Open
Conversation
The implementation is error prone, it had already several bugs in the past and at least I could find another one that basically it does not work proper with leap seconds. This is not yet widely used, before we get more people depending on it and get unexpected bugs, we delete it. If the functionality would be needed in the future, it would be better to rely as much as possible in existing implementations like some of the POSIX / C lib apis.
limdor
requested review from
4og,
antonkri,
arkjedrz,
fbaeuerle and
pawelrutkaq
as code owners
August 13, 2026 12:56
github-actions
Bot
added
comp-datetime
Contributor
|
Documentation preview for this pull request is available at: |
Member
|
Hi @Rutuja-Patil-Bosch, @srinivasugithub, @gierer, You have contributed to this code recently, so we thought we'd check with you before removing it. Are you aware of any remaining use cases, or do you have any concerns about deleting it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation is error prone, it had already several bugs in the past and at least I could find another one that basically it does not work proper with leap seconds.
This is not yet widely used, before we get more people depending on it and get unexpected bugs, we delete it.
If the functionality would be needed in the future, it would be better to rely as much as possible in existing implementations like some of the POSIX / C lib apis.