Trigger Show In on Enter/double-click for projects in Open Resource#4013
Draft
vogella wants to merge 1 commit into
Draft
Trigger Show In on Enter/double-click for projects in Open Resource#4013vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
When a project (or other non-file resource) is selected in the Open Resource dialog, the OK button was disabled and Enter/double-click had no effect. Enable OK in that case and route it to the first available Show In target (MRU-sorted, same ordering as the Show In dropdown), passing the selection as a ShowInContext. Falls back to today's silent close when no Show In target is available.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Open Resource dialog (Ctrl+Shift+R), selecting a project and pressing Enter or double-clicking it had no effect because the OK button was disabled for non-file resources. The selection is now routed to the first available Show In target, using the same MRU-sorted ordering as the Show In dropdown and passing the selection as a
ShowInContext. File selections behave exactly as before, multi-selection of projects stays disabled (Show In targets only reveal one entry), and the dialog still closes silently if the current perspective declares no Show In targets.Planned for 4.41