ddsi: optionally emit related_sample_identity in inline QoS - #2380
Open
Yu1iWoowah wants to merge 7 commits into
Open
ddsi: optionally emit related_sample_identity in inline QoS#2380Yu1iWoowah wants to merge 7 commits into
Yu1iWoowah wants to merge 7 commits into
Conversation
Yu1iWoowah
marked this pull request as draft
April 4, 2026 18:13
Signed-off-by: Tzu Ting Kao <yuliwoowah@gmail.com>
Signed-off-by: Tzu Ting Kao <yuliwoowah@gmail.com>
Signed-off-by: Tzu Ting Kao <yuliwoowah@gmail.com>
Signed-off-by: Tzu Ting Kao <yuliwoowah@gmail.com>
Yu1iWoowah
force-pushed
the
ddsi-related-sample-identity
branch
from
April 4, 2026 21:07
31d0dba to
c33dc1f
Compare
Signed-off-by: Tzu Ting Kao <yuliwoowah@gmail.com>
Yu1iWoowah
marked this pull request as ready for review
April 4, 2026 22:43
Author
|
Converted to ready for review. Checks are green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a minimal internal way to emit the existing RTPS inline QoS parameter
related_sample_identityon outgoing DATA / DATA_FRAG samples.Scope is intentionally small:
dds/dds.hAPIImplementation summary:
DDSI_PID_RELATED_SAMPLE_IDENTITYddsi_serdata_ops.get_related_sample_identityaccessorThis follows the existing
get_keyhashpattern: transmit owns wire encoding, whileserdataprovides sample-specific data when needed.If the accessor is absent, or returns false, behavior is unchanged.
Tests added:
Local verification:
cunit_ddsi -f -s ddsi_related_sample_identitypassedcunit_ddsi -fpassedNon-goals:
dds_writecdr()/dds_forwardcdr()changesMain feedback requested:
ddsi_serdata_opsaccessor the right internal hook for it?