Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/base/src/experiment-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,17 @@ export class ExperimentManager {
return undefined;
}

/**
* Close the given experiment from the server
* @param experimentUUID experiment UUID
*/
async closeExperiment(experimentUUID: string): Promise<void> {
const experimentToDelete = this.fOpenExperiments.get(experimentUUID);
if (experimentToDelete) {
await this.fTspClient.closeExperiment(experimentUUID);
}
}

/**
* Delete the given experiment from the server
* @param experimentUUID experiment UUID
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,15 @@ export class TheiaRpcTspProxy implements ITspClient {
return this.toTspClientResponse<Experiment>(await this.tspClient.updateExperiment(expUUID, parameters));
}

/**
* Close an experiment
* @param expUUID Experiment UUID to close
* @returns The closed experiment
*/
public async closeExperiment(expUUID: string): Promise<TspClientResponse<Experiment>> {
return this.toTspClientResponse<Experiment>(await this.tspClient.closeExperiment(expUUID));
}

/**
* Delete an experiment on the server
* @param expUUID Experiment UUID to delete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@ export class TraceExplorerOpenedTracesWidget extends ReactWidget {

public closeExperiment(traceUUID: string): void {
signalManager().fireCloseTraceViewerTabSignal(traceUUID);
this._experimentManager.closeExperiment(traceUUID);
}

public deleteExperiment(traceUUID: string): void {
this._experimentManager.deleteExperiment(traceUUID);
this.closeExperiment(traceUUID);
this._experimentManager.deleteExperiment(traceUUID);
}

render(): React.ReactNode {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ export class TraceViewerWidget extends ReactWidget implements StatefulWidget {
super.onCloseRequest(msg);
if (this.openedExperiment) {
signalManager().fireExperimentClosedSignal(this.openedExperiment);
this.experimentManager.closeExperiment(this.openedExperiment.UUID);
}
}

Expand Down