Repository navigation
Fix word count of Algorand not existent word test vectors - #162
Merged
ebellocchia merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two "Not existent word" vectors in the Algorand mnemonic tests have 24 words, but an Algorand mnemonic has 25. The decoder rejects them on the word count before it looks up any word, so they never test an unknown word.
I added one valid word to each vector, so both now fail on the word lookup. To check, I changed
GetWordIdxto return 0 instead of raising: the tests still pass on master, and fail with this change. I found this while writing #161; the two merge cleanly, and with both, the Algorand test also checks the unknown-word messages.