Allow overwriting the CUDA sanity check CLI arguments in an EasyConfig#5189
Open
Flamefire wants to merge 1 commit into
Open
Allow overwriting the CUDA sanity check CLI arguments in an EasyConfig#5189Flamefire wants to merge 1 commit into
Flamefire wants to merge 1 commit into
Conversation
For some software it is not possible to e.g. include PTX code or has only PTX code. When that is known then the sanity check should not fail, but only for this easyconfig. Hence allow setting/disabling those checks in an easyconfig. The opposite is also possible: - Disable it on command line - Enable for specific easyconfigs, e.g. via hooks.
Flamefire
force-pushed
the
cuda-sanity-check-cc-params
branch
from
8f4b0a5 to
7df99a9
Compare
ocaisa
reviewed
May 6, 2026
Comment on lines
+3501
to
+3504
| def get_from_easyconfig_or_build_option(self, option_name: str) -> Any: | ||
| """Return the value of this option if it is set (not None) in the easyconfig else from the CLI/config""" | ||
| res = self.cfg.get(option_name) | ||
| return res if res is not None else build_option(option_name) |
Member
There was a problem hiding this comment.
For CUDA compute capabilities what is set in the CLI/config takes precedence over what is in the easyconfig, but in this case, what is in the easyconfig is taking precedence over what is set in the CLI/config. This is likely to lead to confusion (I do not have a solution).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some software it is not possible to e.g. include PTX code or has only PTX code. When that is known then the sanity check should not fail, but only for this easyconfig.
Hence allow setting/disabling those checks in an easyconfig.
The opposite is also possible: