add patch to skip broken test_wrap_bad + add unittest-xml-reporting build dependency to PyTorch 1.13.1#22357
Conversation
1460af9 to
ab8adfe
Compare
|
Test report by @Flamefire |
Updated software
|
77e1827 to
75ccc7f
Compare
|
Test report by @Flamefire |
8ca16b2 to
337a4d5
Compare
|
Test report by @Flamefire |
test_wrap_bad + add unittest-xml-reporting build dependency to PyTorch 1.13.1
|
@boegelbot please test @ jsc-zen3-a100 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 4209062147 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegel it is failing on this new check:
Introduced in easybuilders/easybuild-easyblocks#4049 which needs to also consider The other failure is machine specific fixed by using the patch from #20176 which is already used in the non-CUDA version |
this is a perfect example why it's better to use PythonBundle over PythonPackage in general:
i understand if it's too much hassle to change to PythonBundle for PyTorch, that's why there's still the option to disable the check in the easyconfig: sanity_check_pip_list = False |
Yes, we would need to change all PyTorch easyconfigs. |
|
only open PyTorch PRs need to be changed, but i see you just opened a lot of them recently, i'm sorry for that.. i can help you with that if you want?
|
|
Maybe that is the chance to port those to PythonBundle. But we definitely need some documentation somewhere that PythonBundle should be used when Software name and PYPI name are different and when to use PythonPackage. As for PyTorch PRs: We need to merge #25737 first, then I can start updating the PRs. I think I'll use that to try how well AI copes with that. ;-) |
…o `PyTorch-1.13.1-foss-2022b-CUDA-11.7.0.eb`
2182e8d to
51a7ac3
Compare
|
I spent some time and (together with CoPilot) created a script which automatically converts the PyTorch easyconfigs to PythonBundle. A wrapper will let it run over all my open PRs. Tricky part:
This doesn't work because we don't allow multiple sources for extensions due to legacy reasons. |
d73eb67 to
b0e342b
Compare
312bb5e to
51a7ac3
Compare
(created using
eb --new-pr)Requires: