Repository navigation
chore(tests): unify byte format - #896
Merged
Merged
Conversation
harry-whorlow
force-pushed
the
standardise-sizes
branch
from
November 17, 2026 14:49
2518c77 to
a2920ae
Compare
harry-whorlow
commented
Nov 17, 2026
| requestThroughput: Math.round(tests.requestThroughput).toLocaleString(), | ||
| latency: `${Number(tests.latency.toFixed(3))}${tests.latencyUnit}`, | ||
| bodySize: `${tests.bodySize.value} ${tests.bodySize.unit}`, | ||
| bodySize: `${Number((tests.bodySize.value / 1024).toFixed(2))} KiB`, |
Contributor
Author
There was a problem hiding this comment.
this will be fixed in my other pr
harry-whorlow
commented
Nov 17, 2026
Contributor
Author
There was a problem hiding this comment.
this is for reference, will be deleted on approval
harry-whorlow
commented
Nov 17, 2026
| "validate": "node src/validate-stats.ts", | ||
| "validate:first-party-dependencies": "node src/validate-first-party-dependencies.ts", | ||
| "sync:versions": "node src/sync-versions.ts", | ||
| "migrate:body-size-bytes": "node src/migrate-body-size-to-bytes.ts", |
Contributor
Author
There was a problem hiding this comment.
also will be deleted
harry-whorlow
marked this pull request as ready for review
November 17, 2026 21:11
harry-whorlow
requested review from
43081j and
AlexanderKaran
as code owners
November 17, 2026 21:11
Member
|
so this shouldn't be reviewed at all? @harry-whorlow |
Contributor
Author
This should be reviewed... though it was a programmatic conversion from kb to bytes. My comments were referring to the files I commented on, the files are for reference as to how I converted the data. The actual data changes are what will be merged. |
AlexanderKaran
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formats byte sizes across tests