Skip to content

chore(tests): unify byte format - #896

Merged
AlexanderKaran merged 3 commits into
e18e:mainfrom
harry-whorlow:standardise-sizes
Nov 19, 2026
Merged

AlexanderKaran merged 3 commits into
e18e:mainfrom
harry-whorlow:standardise-sizes

Conversation

@harry-whorlow

@harry-whorlow harry-whorlow commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

formats byte sizes across tests

requestThroughput: Math.round(tests.requestThroughput).toLocaleString(),
latency: `${Number(tests.latency.toFixed(3))}${tests.latencyUnit}`,
bodySize: `${tests.bodySize.value} ${tests.bodySize.unit}`,
bodySize: `${Number((tests.bodySize.value / 1024).toFixed(2))} KiB`,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be fixed in my other pr

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for reference, will be deleted on approval

Comment thread packages/stats-generator/package.json Outdated
"validate": "node src/validate-stats.ts",
"validate:first-party-dependencies": "node src/validate-first-party-dependencies.ts",
"sync:versions": "node src/sync-versions.ts",
"migrate:body-size-bytes": "node src/migrate-body-size-to-bytes.ts",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also will be deleted

@harry-whorlow
harry-whorlow marked this pull request as ready for review November 17, 2026 21:11
@dreyfus92

Copy link
Copy Markdown
Member

so this shouldn't be reviewed at all? @harry-whorlow

@harry-whorlow

harry-whorlow commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

so this shouldn't be reviewed at all? @harry-whorlow

This should be reviewed... though it was a programmatic conversion from kb to bytes.

My comments were referring to the files I commented on, the files are for reference as to how I converted the data. The actual data changes are what will be merged.

@AlexanderKaran
AlexanderKaran merged commit 549cc12 into e18e:main Nov 19, 2026
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants