Repository navigation
Add Nifra framework benchmarks - #848
Closed
TechDev009 wants to merge 2 commits into
Closed
TechDev009 wants to merge 2 commits into
TechDev009 wants to merge 2 commits into
Conversation
Collaborator
|
Hi @TechDev009 Thank you for the PR. We actually have a process for adding new benchmarks: https://github.com/e18e/framework-performance/blob/main/CONTRIBUTING.md#adding-a-new-framework Please give it a read and follow the steps. Will close this PR for now. |
Author
|
@AlexanderKaran ok let do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Nifra starter and runtime fixtures, registry/configuration, benchmark runners, docs, and logo.
The production path now stays on Nifra's fast implementation:
Evidence
After: Nifra is wired into install/build/dev/browser/SSR/SSR-load/router-link measurements with exact 5.13.0 pins.
{ fetch }, hiding the Node-direct lane.After: the runtime serves the built app object directly, and the in-process handler imports that same native build.
After:
/framework/nifra/, logo, methodology, and README data links are included.Verified locally:
pnpm run type-checkandpnpm run buildinpackages/starter-nifraandpackages/app-nifranifra check --jsonin both packagesapp.resolveNodeand HTTP/static-asset smoke checkspnpm --config.engine-strict=false --filter @framework-performance/stats-generator lintpnpm --config.engine-strict=false --filter @framework-performance/stats-generator test(83 passing)pnpm --config.engine-strict=false --filter @framework-performance/docs buildMerge Danger
Door: two-way
Blast Radius: benchmark-only