Skip to content

Fix locale-dependent strftime breaking HMAC auth #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AaronAtDuo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix locale-dependent strftime breaking HMAC auth #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/https.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <string.h>
#include <unistd.h>
#include <fcntl.h>
#include <locale.h>

#include <openssl/bio.h>
#include <openssl/err.h>
Expand Down Expand Up @@ -929,11 +930,18 @@ https_send(struct https_request *req, const char *method, const char *uri,
char *qs, *p, date[128];
int i, n, is_get;
time_t t;
locale_t c_locale;

req->done = 0;

t = time(NULL) + time_offset; /* adjust time by offset */
strftime(date, sizeof date, "%a, %d %b %Y %T %z", localtime(&t));
c_locale = newlocale(LC_TIME_MASK, "C", (locale_t)0);
if (c_locale == (locale_t)0) {
ctx.errstr = "Failed to create C locale";
return (HTTPS_ERR_LIB);
}
strftime_l(date, sizeof date, "%a, %d %b %Y %T +0000", gmtime(&t), c_locale);
freelocale(c_locale);

/* Generate query string and canonical request to sign */
if ((qs = _argv_to_qs(argc, argv)) == NULL) {
Expand Down
Loading