Remove dev_fips_mode config option#365
Merged
Merged
Conversation
dev_fips_mode was designed for OpenSSL 1.x FIPS 140-2 application-level activation via FIPS_mode_set(). OpenSSL 3.x replaced this with a provider-based model where FIPS is enabled system-wide, not per-application. FIPS_mode_set() is a no-op or absent on OpenSSL 3.x, making dev_fips_mode non-functional since OpenSSL 3.x shipped. Production FIPS has always worked via system configuration, not this option. Removed from: struct duo_config, duo_config_default(), duo_common_ini_handler(), login_duo.c, pam_duo.c, and all associated tests and test configs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeffreyparker
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev_fips_mode was designed for OpenSSL 1.x FIPS 140-2 application-level activation via FIPS_mode_set(). OpenSSL 3.x replaced this with a provider-based model where FIPS is enabled system-wide, not per-application. FIPS_mode_set() is a no-op or absent on OpenSSL 3.x, making dev_fips_mode non-functional since OpenSSL 3.x shipped. Production FIPS has always worked via system configuration, not this option.
Removed from: struct duo_config, duo_config_default(), duo_common_ini_handler(), login_duo.c, pam_duo.c, and all associated tests and test configs.
Test Plan
Tests should pass