Skip to content

fix: improve dark mode text contrast in mobile nav #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roopamdeep wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: improve dark mode text contrast in mobile nav #3591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2d4516
fix: improve dark mode text contrast in mobile nav
roopamdeep Mar 16, 2026
fd4c66b
Merge branch 'main' into fix/brand-mobile-nav-contrast
roopamdeep Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/ui/src/nav/nav-mobile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ export function NavMobile({
)}
>
{open ? (
<X className="h-5 w-5 text-neutral-600 dark:text-white/70" />
<X className="h-5 w-5 text-neutral-600 dark:text-white" />
) : (
<Menu className="h-5 w-5 text-neutral-600 dark:text-white/70" />
<Menu className="h-5 w-5 text-neutral-600 dark:text-white" />
)}
</button>
<nav
className={cn(
"fixed inset-0 z-20 hidden max-h-screen w-full overflow-y-auto bg-white px-5 py-16 lg:hidden dark:bg-black dark:text-white/70",
"fixed inset-0 z-20 hidden max-h-screen w-full overflow-y-auto bg-white px-5 py-16 lg:hidden dark:bg-black dark:text-white",
open && "block",
)}
>
Expand Down