Drop the Homebrew cask until the tap has a token - #2
Merged
Conversation
The cask's skip_upload guard meant a release would publish and silently omit the cask, leaving `brew install dsaad68/tap/kaku-tab` in the README and the release footer pointing at nothing. Point both at the tarballs instead, which is what a release actually ships. The cask config is commented out rather than deleted: re-enabling it is uncommenting two blocks and adding HOMEBREW_TAP_TOKEN as a repo secret. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release would have published archives and silently skipped the cask (the
skip_uploadguard fires whenHOMEBREW_TAP_TOKENis absent, and it is), sobrew install dsaad68/tap/kaku-tabin the README and the release footer wouldpoint at something that does not exist.
releases page, with the Gatekeeper
xattrnote the cask used to handle..goreleaser.yaml: cask commented out, footer points at tarballs /go install.release.yml: the now-unusedHOMEBREW_TAP_TOKENenv line commented out.Re-enabling is uncommenting the two blocks and adding the secret.
Verified locally:
goreleaser checkpasses, andrelease --snapshot --clean --skip=publishbuilds all four platforms, with archives unpacking to a plainkaku-tab.🤖 Generated with Claude Code