Skip to content

Fix MAVLink tunnel reconnect and shutdown - #100

Open
dhairyajangir wants to merge 1 commit into
dronecan:masterfrom
dhairyajangir:fix/61-mavlink-tunnel
Open

dhairyajangir wants to merge 1 commit into
dronecan:masterfrom
dhairyajangir:fix/61-mavlink-tunnel

Conversation

@dhairyajangir

@dhairyajangir dhairyajangir commented Nov 10, 2026 •

Copy link
Copy Markdown

Fixes #61.

The MAVLink tunnel called join() on the worker function during Ctrl-C. Its TCP worker could also stay on a disconnected client and miss the next connection. Treat EOF and reset as the end of the current client. During shutdown, stop accepting clients and wake any blocked receive before joining the worker and closing the CAN node.

Three subprocess tests exercise the real example with loopback TCP and a stub CAN node. They cover idle and connected Ctrl-C, bidirectional forwarding across reconnect, and reconnect after a reset. All three fail on the current upstream base and pass with the change. The Linux CI commands passed locally on Python 3.8 through 3.14, with 61 unit tests per version and passing installed-package tests.

The change and tests were prepared with Codex assistance.

Could a maintainer authorize the Python package workflow when convenient?

@dhairyajangir
dhairyajangir marked this pull request as ready for review November 10, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mavlink Tunnel Example, .join called on function not thread

1 participant