Repository navigation
Fix MAVLink tunnel reconnect and shutdown - #100
Open
dhairyajangir wants to merge 1 commit into
Open
dhairyajangir wants to merge 1 commit into
dhairyajangir wants to merge 1 commit into
Conversation
dhairyajangir
marked this pull request as ready for review
November 10, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61.
The MAVLink tunnel called
join()on the worker function during Ctrl-C. Its TCP worker could also stay on a disconnected client and miss the next connection. Treat EOF and reset as the end of the current client. During shutdown, stop accepting clients and wake any blocked receive before joining the worker and closing the CAN node.Three subprocess tests exercise the real example with loopback TCP and a stub CAN node. They cover idle and connected Ctrl-C, bidirectional forwarding across reconnect, and reconnect after a reset. All three fail on the current upstream base and pass with the change. The Linux CI commands passed locally on Python 3.8 through 3.14, with 61 unit tests per version and passing installed-package tests.
The change and tests were prepared with Codex assistance.
Could a maintainer authorize the Python package workflow when convenient?