Skip to content

don't panic when sending error response to disconnected client #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoyo930021 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

don't panic when sending error response to disconnected client #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/bin/rbw-agent/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,19 @@ impl Agent {
let res =
handle_request(&mut sock, state.clone()).await;
if let Err(e) = res {
// unwrap is the only option here
sock.send(&rbw::protocol::Response::Error {
error: format!("{e:#}"),
})
.await
.unwrap();
// the client may have disconnected already, so
// we can't do anything useful with a send
// failure; just log it instead of panicking
if let Err(send_err) = sock
.send(&rbw::protocol::Response::Error {
error: format!("{e:#}"),
})
.await
{
log::warn!(
"failed to send error response to client: {send_err:#}"
);
}
}
});
}
Expand Down
Loading