Skip to content

Fix Nullable<T> detection inside MetadataLoadContext to emit proper BamlRecordType #11816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h3xds1nz wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −2
Open

Fix Nullable<T> detection inside MetadataLoadContext to emit proper BamlRecordType #11816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e782b02
Fix Nullable<T> detection inside MetadataLoadContext to emit proper B…
h3xds1nz Aug 4, 2026
ddad1c2
Fix NET472 as well during compilation
h3xds1nz Aug 4, 2026
9c05eaa
Whoever invented AppDomains... well, you know...
h3xds1nz Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/Microsoft.DotNet.Wpf/src/Shared/System/Windows/Markup/ReflectionHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#nullable disable
Expand Down Expand Up @@ -119,7 +119,14 @@ internal static Type GetQualifiedType(string typeName)

internal static bool IsNullableType(Type type)
{
return (type.IsGenericType && (type.GetGenericTypeDefinition() == typeof(Nullable<>)));
#if NET11_0_OR_GREATER
return type.GetNullableUnderlyingType() is not null;
#else
Type nullableType = _metadataLoadContext.CoreAssembly?.GetType("System.Nullable`1");
Debug.Assert(nullableType is not null, "System.Nullable`1 type not found in MetadataLoadContext");

return type.IsGenericType && nullableType == type.GetGenericTypeDefinition();
#endif
}

internal static bool IsInternalType(Type type)
Expand Down