Make UCO MethodDesc globals DAC-accessible#126927

Merged

jkotas merged 8 commits intodotnet:mainfrom

am11:feature/MDCS-to-UCOA-pattern3

Apr 15, 2026

Member

am11 commented Apr 15, 2026

No description provided.

github-actions bot added the area-VM-coreclr label

dotnet-policy-service bot added the community-contribution label

am11 requested review from janvorli and jkotas

April 15, 2026 00:28

Contributor

dotnet-policy-service bot commented Apr 15, 2026

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Member

hoyosjs commented Apr 15, 2026

Is there a reason to explicitly hide these from the DBI? I see they are decorated with debugger hidden. What makes them different from others?

Member Author

am11 commented Apr 15, 2026

@janvorli found some internal debugging tests are failing on main #126809 (comment). The actual thing we were trying to fix was #126869, but so far, there is no repro.


          Make UCO MethodDesc globals DAC-accessible

18f05b7

am11 force-pushed the feature/MDCS-to-UCOA-pattern3 branch from 64b9459 to 18f05b7 Compare

April 15, 2026 02:07

am11 mentioned this pull request

Convert funceval to UCO pattern #126809

Open

jkotas reviewed

View reviewed changes

src/coreclr/vm/proftoeeinterfaceimpl.cpp Outdated

src/coreclr/vm/proftoeeinterfaceimpl.cpp Outdated

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp Outdated

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp Outdated

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp Outdated

src/coreclr/debug/ee/controller.cpp

src/coreclr/debug/ee/controller.cpp Outdated


          Apply suggestions from code review

cf9ec87

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas reviewed

View reviewed changes

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp


          Apply suggestion from @jkotas

fe6ce94

jkotas reviewed

View reviewed changes

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp Outdated


          Apply suggestion from @jkotas

def6290

jkotas reviewed

View reviewed changes

src/coreclr/debug/ee/controller.cpp Outdated


          Apply suggestion from @jkotas

25f5bec

jkotas reviewed

View reviewed changes

src/coreclr/debug/ee/controller.cpp Outdated


          Apply suggestion from @jkotas

341ab29

jkotas approved these changes

View reviewed changes

Member

jkotas left a comment

Thanks

Member

jkotas commented Apr 15, 2026

cc @dotnet/dotnet-diag-contrib

jkotas reviewed

View reviewed changes

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp

src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp Outdated

jkotas added 2 commits

April 14, 2026 21:31


          Update src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp

aaf379a


          Update src/coreclr/debug/daccess/dacdbiimplstackwalk.cpp

1210a25

This was referenced Apr 15, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

System.Net.NameResolution.Tests DNS failures: Name or service not known #126641

Open

hoyosjs approved these changes

View reviewed changes

Member

hoyosjs left a comment

Not against this. To me tests failing due to a new managed frame is a test bug - but if we think more things on the ecosystem expect to see main being the first managed frame - this is ok to me, I don't see a lot of value in seeing this frame.

Member

jkotas commented Apr 15, 2026

/ba-g Trimming test failure has been fixed in main already

jkotas merged commit 39314d4 into dotnet:main

109 of 113 checks passed

am11 deleted the feature/MDCS-to-UCOA-pattern3 branch

April 15, 2026 19:41

dotnet-maestro bot mentioned this pull request

[main] Source code updates from dotnet/runtime dotnet/dotnet#6035

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr community-contribution