-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Bump Android minimum API level from 21 to 24 #126838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2590cd0
18fef16
58e5bf6
d150ef8
ad108f5
57db7b2
7c91e8d
46f9e5f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -101,7 +101,7 @@ build_native() | |||||
|
|
||||||
| if [[ "$targetOS" == android || "$targetOS" == linux-bionic ]]; then | ||||||
| # Keep in sync with $(AndroidApiLevelMin) in Directory.Build.props in the repository rooot | ||||||
|
||||||
| # Keep in sync with $(AndroidApiLevelMin) in Directory.Build.props in the repository rooot | |
| # Keep in sync with $(AndroidApiLevelMin) in Directory.Build.props in the repository root |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -76,7 +76,7 @@ if /i "%__Arch%" == "wasm" ( | |||||
|
|
||||||
| if /i "%__Os%" == "android" ( | ||||||
| :: Keep in sync with $(AndroidApiLevelMin) in Directory.Build.props in the repository rooot | ||||||
|
||||||
| :: Keep in sync with $(AndroidApiLevelMin) in Directory.Build.props in the repository rooot | |
| :: Keep in sync with $(AndroidApiLevelMin) in Directory.Build.props in the repository root |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,7 +107,7 @@ public static void IsOSPlatformVersionAtLeast_InvalidArgs_Throws() | |
| public static void TestIsOSVersionAtLeast_Android() => TestIsOSVersionAtLeast("Android"); | ||
|
|
||
| [Fact, PlatformSpecific(TestPlatforms.Android)] | ||
| public static void TestIsOSVersionAtLeast_Android_21() => Assert.True(OperatingSystem.IsAndroidVersionAtLeast(21)); // 21 is our min supported version | ||
| public static void TestIsOSVersionAtLeast_Android_24() => Assert.True(OperatingSystem.IsAndroidVersionAtLeast(24)); // 24 is our min supported version | ||
|
Comment on lines
109
to
+110
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test should actually still pass unchanged, can you introduce a new test and keep the old one? (or use
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, we could do that, but I don't see a value of such test. If anything, we might want to completely drop this test. |
||
|
|
||
| [Fact, PlatformSpecific(TestPlatforms.iOS)] | ||
| public static void TestIsOSPlatform_IOS() => TestIsOSPlatform("iOS", OperatingSystem.IsIOS); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above is a list of all the files that might be hardcoding 21, this PR is missing some.