Skip to content

Improve Math.BigMul to fix Decimal compare perf regression #115182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Daniel-Svensson wants to merge 2 commits into from

Fix typo

18482a8
Select commit
Loading
Failed to load commit list.
Closed

Improve Math.BigMul to fix Decimal compare perf regression #115182

Fix typo
18482a8
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime failed May 10, 2025 in 2h 17m 45s

Build #20250509.51 had test failures

5 errors / 10,199 warnings

Details

Tests

  • Failed: 6 (0.00%)
  • Passed: 4,056,623 (98.29%)
  • Other: 70,370 (1.71%)
  • Total: 4,126,999

Annotations

Check failure on line 91 in .packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91 

.packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Runtime.Tests in job d710522b-3275-48ce-8d41-d815b89980d4 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/d710522b-3275-48ce-8d41-d815b89980d4/workitems/System.Runtime.Tests/console

Check failure on line 91 in .packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25257.112\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25257.112\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91 

.packages\microsoft.dotnet.helix.sdk\10.0.0-beta.25257.112\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item WasmTestOnChrome-ST-System.Runtime.InteropServices.JavaScript.Tests in job 12d40729-a8db-4d0a-9038-c65699218db1 has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/12d40729-a8db-4d0a-9038-c65699218db1/workitems/WasmTestOnChrome-ST-System.Runtime.InteropServices.JavaScript.Tests/console

Check failure on line 44 in .packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/azure-pipelines/AzurePipelines.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/azure-pipelines/AzurePipelines.MultiQueue.targets#L44 

.packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/azure-pipelines/AzurePipelines.MultiQueue.targets(44,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Test baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/ee35e095-f0e7-464e-b02d-a5967199ce66/workitems/baseservices-exceptions/console

Check failure on line 91 in .packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

.packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets#L91 

.packages/microsoft.dotnet.helix.sdk/10.0.0-beta.25257.112/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(91,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item WasmTestOnChrome-ST-System.Runtime.Intrinsics.Tests in job 6890cb07-1224-42d4-af82-90dbd895a1cd has failed.
Failure log: https://helix.dot.net/api/2019-06-17/jobs/6890cb07-1224-42d4-af82-90dbd895a1cd/workitems/WasmTestOnChrome-ST-System.Runtime.Intrinsics.Tests/console

Check failure on line 1 in System.Runtime.Tests.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

System.Runtime.Tests.WorkItemExecution 

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.

Check failure on line 1 in WasmTestOnChrome-ST-System.Runtime.Intrinsics.Tests.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

WasmTestOnChrome-ST-System.Runtime.Intrinsics.Tests.WorkItemExecution 

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.

Check failure on line 1 in WasmTestOnChrome-ST-System.Runtime.Tests.WorkItemExecution

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

WasmTestOnChrome-ST-System.Runtime.Tests.WorkItemExecution 

The Helix Work Item failed. Often this is due to a test crash. Please see the 'Artifacts' tab above for additional logs.

Check failure on line 1 in baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd 

cmdLine:/datadisks/disk1/work/B021095A/w/AA0D09A2/e/baseservices/exceptions/baseservices-exceptions/../stackoverflow/stackoverflowtester/stackoverflowtester.sh Timed Out (timeout in milliseconds: 600000 from variable __TestTimeout, start: 5/9/2025 11:31:02 PM, end: 5/9/2025 11:41:02 PM)

Return code:      -100
Raw output file:      /datadisks/disk1/work/B021095A/w/AA0D09A2/uploads/stackoverflow/stackoverflowtester/output.txt
Raw output:
BEGIN EXECUTION
/datadisks/disk1/work/B021095A/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true stackoverflowtester.dll ''
Running stackoverflow test(smallframe main)
"Stack overflow."
"Repeated 174494 times:"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB()"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.InfiniteRecursionC()"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB()"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.Test(Boolean)"
"   at TestStackOverflow.Program.Main(System.String[])"
"@Exiting stack trace printing thread."
"@Stack trace printing helper thread exited."
"@Proceeding with exit."
"@Setting throwable."
"@Calling WatsonLastChance."
"@Terminating the process."
""
Running stackoverflow test(largeframe main)
"Stack overflow."
"Repeated 42 times:"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB2()"
"   at TestStackOverflow.Program.InfiniteRecursionA2()"
"   at TestStackOverflow.Program.InfiniteRecursionC2()"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB2()"
"   at TestStackOverflow.Program.InfiniteRecursionA2()"
"   at TestStackOverflow.Program.Test(Boolean)"
"   at TestStackOverflow.Program.Main(System.String[])"
"@Exiting stack trace printing thread."
"@Stack trace printing helper thread exited."
"@Proceeding with exit."
"@Setting throwable."
"@Calling WatsonLastChance."
"@Terminating the process."
""
Running stackoverflow test(smallframe secondary)
"Stack overflow."
"Repeated 174644 times:"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB()"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.InfiniteRecursionC()"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB()"
"   at TestStackOverflow.Program.InfiniteRecursionA()"
"   at TestStackOverflow.Program.Test(Boolean)"
"   at TestStackOverflow.Program+<>c__DisplayClass7_0.<SecondaryThreadsTest>b__0()"
"   at System.Threading.Thread.StartCallback()"
"@Exiting stack trace printing thread."
"@Stack trace printing helper thread exited."
"@Proceeding with exit."
"@Setting throwable."
"@Calling WatsonLastChance."
"@Terminating the process."
""
Running stackoverflow test(largeframe secondary)
"Stack overflow."
"Repeated 42 times:"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB2()"
"   at TestStackOverflow.Program.InfiniteRecursionA2()"
"   at TestStackOverflow.Program.InfiniteRecursionC2()"
"--------------------------------"
"   at TestStackOverflow.Program.InfiniteRecursionB2()"
"   at TestStackOverflow.Program.InfiniteRecursionA2()"
"   at TestStackOverflow.Program.Test(Boolean)"
"   at TestStackOverflow.Program+<>c__DisplayClass7_0.<SecondaryThreadsTest>b__0()"
"   at System.Threading.Thread.StartCallback()"
"@Exiting stack trace printing thread."
"Stack overflow occurred on the same thread again!"

cmdLine:/datadisks/disk1/work/B021095A/w/AA0D09A2/e/baseservices/exceptions/baseservices-exceptions/../stackoverflow/stackoverflowtester/stackoverflowtester.sh Timed Out (timeout in milliseconds: 600000 from variable __TestTimeout, start: 5/9/2025 11:31:02 PM, end: 5/9/2025 11:41:02 PM)
Printing stacktrace from '/home/helixbot/dotnetbuild/dumps/crash
Raw output 
   at Xunit.Assert.True(Nullable`1 condition, String userMessage) in /_/src/arcade/src/Microsoft.DotNet.XUnitAssert/src/BooleanAsserts.cs:line 141
   at Program.<<Main>$>g__TestExecutor17|0_18(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
View more details on Azure Pipelines