Re-enable Build Acceleration within the solution#9244
Open
drewnoakes wants to merge 1 commit intodotnet:mainfrom
Open
Re-enable Build Acceleration within the solution#9244drewnoakes wants to merge 1 commit intodotnet:mainfrom
drewnoakes wants to merge 1 commit intodotnet:mainfrom
Conversation
When Build Acceleration observes the Microsoft.VSSDK.BuildTools package in the project, it disables itself out of caution, as VSIX projects cannot be accelerated (they must call MSBuild in order to pack the VSIX). In our solution we were adding this VSSDK package to every project, effectively disabling it entirely within the solution. This change removes it from VisualStudio.props and adds it only to the VSIX project files themselves.
kvenkatrajan
approved these changes
Aug 31, 2023
haileymck
approved these changes
Aug 31, 2023
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tmeschter
approved these changes
Oct 2, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Build Acceleration observes the
Microsoft.VSSDK.BuildToolspackage in the project, it disables itself out of caution, as VSIX projects cannot be accelerated (they must call MSBuild in order to pack the VSIX).In our solution we were adding this VSSDK package to every project, effectively disabling it entirely within the solution.
This change removes it from VisualStudio.props and adds it only to the VSIX project files themselves.
NOTE: This only impacts our team's development experience. This doesn't change anything for users of the project system in VS.
Microsoft Reviewers: Open in CodeFlow