Skip to content

Improve XML documentation for GetMappingStrategy return values #38091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 3 commits into from
Apr 14, 2026
+15 −2
Merged

Improve XML documentation for GetMappingStrategy return values #38091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63566f0
Initial plan
Copilot Apr 13, 2026
86874c0
Improve XML docs for GetMappingStrategy to reference possible return …
Copilot Apr 13, 2026
ff30fd3
Apply suggestions from code review
AndriySvyryd Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1518,7 +1518,13 @@ public static void SetIsTableExcludedFromMigrations(
/// Gets the mapping strategy for the derived types.
/// </summary>
/// <param name="entityType">The entity type.</param>
/// <returns>The mapping strategy for the derived types.</returns>
/// <returns>
/// The mapping strategy for the derived types, or <see langword="null" /> if no strategy is configured
/// and the entity type has no derived types. Well-known values include
/// <see cref="RelationalAnnotationNames.TphMappingStrategy" />,
/// <see cref="RelationalAnnotationNames.TptMappingStrategy" />, and
/// <see cref="RelationalAnnotationNames.TpcMappingStrategy" />, but other values may be returned if configured.
/// </returns>
public static string? GetMappingStrategy(this IReadOnlyEntityType entityType)
=> (string?)entityType[RelationalAnnotationNames.MappingStrategy]
?? (entityType.BaseType != null
Expand Down
9 changes: 8 additions & 1 deletion src/EFCore.Relational/Extensions/RelationalTypeBaseExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,14 @@ public static IEnumerable<IEntityTypeMappingFragment> GetMappingFragments(
/// Gets the mapping strategy for the derived types.
/// </summary>
/// <param name="typeBase">The type.</param>
/// <returns>The mapping strategy for the derived types.</returns>
/// <returns>
/// The mapping strategy for the derived types, or <see langword="null" /> if no strategy is configured
/// and the entity type has no derived types. Well-known values are
/// <see cref="RelationalAnnotationNames.TphMappingStrategy" />,
/// <see cref="RelationalAnnotationNames.TptMappingStrategy" />, and
/// <see cref="RelationalAnnotationNames.TpcMappingStrategy" />, but other values may be returned
/// if a different mapping strategy has been configured.
/// </returns>
public static string? GetMappingStrategy(this IReadOnlyTypeBase typeBase)
=> typeBase.ContainingEntityType.GetMappingStrategy();

Expand Down
Loading