[release/10.0] Support detached signature verification for tars and zips#16737
Merged
ellahathaway merged 7 commits intorelease/10.0from Apr 22, 2026
Merged
[release/10.0] Support detached signature verification for tars and zips#16737ellahathaway merged 7 commits intorelease/10.0from
ellahathaway merged 7 commits intorelease/10.0from
Conversation
…verifiers The parameter name 'supportsDetachedSignature' implied capability support, but it actually controls whether verifiers look for a detached signature (.sig file) instead of a non-detached signature. Rename to 'signatureIsDetached' to better reflect the semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Michael Simons <msimons@microsoft.com>
Move detached signature concept out of PgpVerifier and into the subclasses that use it (TarVerifier, ZipVerifier). Make GetSignatureDocumentAndSignableContent abstract again, and provide reusable helpers (VerifyDetachedSignature, GetDetachedSignatureDocument AndSignableContent) for subclasses with detached signatures.
ellahathaway
approved these changes
Apr 21, 2026
mmitche
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16574 to release/10.0
/cc @ellahathaway