Avoid circleci fail#244
Open
phaberest wants to merge 2 commits intodominikbraun:mainfrom
Open
Conversation
phaberest
force-pushed
the
circleci-fix
branch
from
eebd853 to
b1b7b84
Compare
phaberest
force-pushed
the
circleci-fix
branch
from
b1b7b84 to
2a4bce2
Compare
phaberest
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted a quick fix as I saw that circleci is complaining on the
go get -uistruction ad thus failing to do its checksNB: I didn't notice #196, you can ignore this if this is not useful. In any case whatever the solution will be it will be better than having that "failed" status while the tests are green 😅