#81 Rename project file#133
Open
joshuaherrera wants to merge 5 commits intodominikbraun:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #81 .
Since the
revertcommand relied on the key to get the right backup, I had to make some changes to that logic as well. I decided to always ensure the backup filename matches the current file, which meant when a project filename is changed, so is the backup file.I also had to make a change to the
BackupRecordfunction so that it takes a Record type instead of a string as an argument. This change will effect how therevertworks with the records as well, so my other PR that resolves #89 is effected by this change.