Skip to content

Fix type of RFAdjointMat vector, and fix typo in RFMat.multHermitian #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JHopeCollins wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix type of RFAdjointMat vector, and fix typo in RFMat.multHermitian #252

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44c7deb
fix typo in ReducedFunctionalMatBase.multHermitian
JHopeCollins Mar 9, 2026
bdff22a
tao rf mat: abstract property for x/y interface
JHopeCollins Apr 8, 2026
c75e3b4
RFMatBase docstrings
JHopeCollins Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pyadjoint/optimization/tao_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,13 @@ def mult(self, A, x, y):
if self._shift != 0:
y.axpy(self._shift, x)

def multHermitian(self, A, x, y):
self.yinterface.from_petsc(x, self.x)
out = self.multHermitian_impl(A, self.x)
self.xinterface.to_petsc(y, out)
def multHermitian(self, AT, y, x):
self.yinterface.from_petsc(y, self.y)
Comment thread
jrmaddison marked this conversation as resolved.
out = self.multHermitian_impl(AT, self.y)
self.xinterface.to_petsc(x, out)
Comment thread
jrmaddison marked this conversation as resolved.

if self._shift != 0:
y.axpy(self._shift, x)
x.axpy(self._shift, y)

def mult_impl(self, A, x):
"""
Expand Down Expand Up @@ -355,7 +355,7 @@ def __init__(self, rf, *, apply_riesz=False, appctx=None,

self.xinterface = self.functional_interface
self.yinterface = self.control_interface
self.x = rf.functional._ad_copy()
self.x = rf.functional._ad_init_zero(dual=True)

@classmethod
def update_adjoint(self):
Expand Down