Skip to content

Fix SingleMemoryStorageSchedule checkpoint clearing during forward replay #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sghelichkhani wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −1
Open

Fix SingleMemoryStorageSchedule checkpoint clearing during forward replay #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1e40b7
Fix SingleMemoryStorageSchedule incorrectly clearing checkpoints
sghelichkhani Feb 15, 2026
be651ab
Only clear SingleMemoryStorageSchedule checkpoints once adjoint depen…
sghelichkhani Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pyadjoint/checkpointing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,16 @@ def _(self, cp_action, progress_bar, functional=None, **kwargs):

# Handle the case for SingleMemoryStorageSchedule
if isinstance(self._schedule, SingleMemoryStorageSchedule):
if step > 1 and var not in self.tape.timesteps[step - 1].adjoint_dependencies:
# `var` is used by a block in this step, so the adjoint of
# this step may still need it as a linearisation point.
# Only clear once the adjoint dependencies have been
# revised by a reverse pass and `var` is provably not one
# of them; before that, keeping every dependency in memory
# is exactly what this schedule promises.
if (
current_step._revised_adj_deps
and var not in current_step.adjoint_dependencies
):
var.checkpoint = None
continue

Expand Down