-
Notifications
You must be signed in to change notification settings - Fork 40
Implementation of a Parametrised Reduced Functional #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divijghose
wants to merge
48
commits into
dolfin-adjoint:master
Choose a base branch
from
divijghose:parametrised_reduced_functional
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+604
−10
Open
Changes from 9 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
5c72266
Implementation of `ParametrisedReducedFunctional` as a subclass of `R…
divijghose 69b4f42
Add `ParametrisedReducedFunctional` to `__init__`
divijghose afb45b7
Implementation of `ParametrisedReducedFunctional` as a subclass of th…
divijghose 931655c
Implementation of `ParametrisedReducedFunctional` which calls `Reduce…
divijghose f290791
Update pyadjoint/reduced_functional.py
divijghose fb93ec4
Remove `derivative_components` as a kwarg to `ReducedFunctional`
divijghose af191c8
Updated `all_controls` to work if a list of parameters is passed. Eac…
divijghose bfd0d3e
Tests for Parametrised Reduced Functional:
divijghose ce926dc
Added a test to compare `ParametrisedReducedFunctional` against `Redu…
divijghose 24ead4f
Change `parameter_update` to `update_parameters`
divijghose b983316
Update pyadjoint/reduced_functional.py
divijghose fab260b
Update pyadjoint/reduced_functional.py
divijghose 11b384d
Updated `optimize_tape`
divijghose a426418
Updated `parameters` to return a list of `OverloadedType`
divijghose ff38909
Update pyadjoint/reduced_functional.py
divijghose e4dc322
Correct typo in test name
divijghose 9dcfc64
Update `ParametrisedReducedFunctional` to raise an error if an empty …
divijghose 7ac3220
Removed redundant check for parameters being instance of `Control`. T…
divijghose 3d5a619
Changes to the test for Parametrised RF (`test_parametrised_rf`:
divijghose c960fec
Added a mathematical description to the parametrised reduced function…
divijghose 6c07824
Update tests to include a minimzation problem with a quadratic polyno…
divijghose 7147a6c
Import `ParametrisedReducedFunctional` in `optimization.py` and assig…
divijghose c9eddc6
Create a `ParametrisedReducedFunctionalNumpy` class for downstream use.
divijghose 94d3548
Added a test to check for optimisation with a quadratic polynomial us…
divijghose 6bdc6f7
Remove code duplication for `ParametrisedReducedFunctionalNumPy`. The…
divijghose 876942e
Change in `derivative` (and associated tests) to not return a list of…
divijghose 15f2b48
Changes to `hessian` for parametrised RF:
divijghose 91fad19
Changes to `tlm` for paremetrised RF:
divijghose c46b096
Separate out the callbacks for `controls` and `parameters` in paramet…
divijghose a342f53
Stricter tolerances for the TAO solver test
divijghose 3530074
Empty commit to test CI
divijghose 1a2bbd2
Update tests/pyadjoint/test_parametrised_rf.py
divijghose c71c040
Update pyadjoint/reduced_functional.py
divijghose 1060efd
Update pyadjoint/reduced_functional.py
divijghose cd76d26
Fix tests: updated new `complicated_expression` function in the tests
divijghose 5e45110
Fixed a test to avoid controls and parameters appearing on multiple t…
divijghose 4790026
Fix test to be conditionally skipped if petsc4py is not installed
divijghose c075344
Update pyadjoint/reduced_functional.py
divijghose f9c93a9
Update pyadjoint/reduced_functional.py
divijghose 035b60e
Update pyadjoint/reduced_functional.py
divijghose 2f228fb
Remove `ParametrisedReducedFunctional` from `__init__`
divijghose 007a8ac
Remove `ParametrisedReducedFunctional` from `optimization`
divijghose 4f3e0e9
Changes to `reduced_functional.py`:
divijghose 9545ae5
Removed `ParametrisedReducedFunctional` from tests, and added a new t…
divijghose bef36b8
Remove `ParametrisedReducedFunctional` from imports
divijghose 762332f
Fixed taylor test to show more information if something fails
divijghose 6f74a9f
Fix changes to callbacks that break downstream tests
divijghose 47ef338
Linting
divijghose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.