[Inagaki] Implement GameAudio::CircleSoundMgr - #77
Open
joakim-d wants to merge 1 commit into
Open
Conversation
Report for MarioClub_us (55b9b9f - def5a21)📈 Matched code: 46.70% (+0.09%, +2904 bytes) ✅ 6 new matches
📈 1 improvement in an unmatched item
|
joakim-d
force-pushed
the
reverse_circle_sound_mgr
branch
from
August 19, 2026 21:25
970b6f6 to
def5a21
Compare
joakim-d
commented
Aug 19, 2026
|
|
||
| void setEcho(JAISoundHandle *handlePtr, f32 mix); | ||
| JAISoundHandle *startSoundCustom(u32 soundID, u32 p2); | ||
| virtual void loop(); |
Contributor
Author
There was a problem hiding this comment.
Had to move this method because of symbol order
joakim-d
changed the title
joakim-d
marked this pull request as ready for review
August 19, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GameAudio::CircleSoundMgrclass