Match fn_8019A86C and ftCo_800B2AFC - #3176
Merged
ribbanya merged 4 commits intoAug 22, 2026
Merged
Conversation
The bracket-slot writes are a four-iteration loop over the tournament data, not four unrolled stores through a BracketEntry pointer. Indexing the array directly inside the loop creates the element-offset multiply after the stored value's load, which is the order retail colours (mulli in r0, the loaded byte in r4). Retune PAD_STACK for the local that the pointer no longer occupies.
Each mpCheckFloor probe's position, normal, line and flags are used only inside the case that runs it, and retail allocates them as one contiguous block per call site, so they are declared in their own case blocks. The probe itself is written out per case the way ftCo_800AEA8C already is: found starts at 0 and doubles as the filter gobj argument, and the ignored-floor test joins through a one-case switch. Calling ftCo_IsIgnoredFloor through one more inline level keeps ftCo_800A1B38 out of line without the _noinline wrapper, whose per-site temporaries were taking the stack slots retail leaves below the last probe block. ftCo_800B2AFC 99.9102% -> 100%; every other function in the TU is byte-identical.
MarkMcCaskey
marked this pull request as ready for review
August 22, 2026 18:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting some
“easy”wins to push us to 90% lol