Skip to content

Fix Item_8026AD20 argument - #3089

Draft
g-guthrie wants to merge 2 commits into
doldecomp:masterfrom
g-guthrie:agent/fix-item-throw-argument
Draft

Fix Item_8026AD20 argument#3089
g-guthrie wants to merge 2 commits into
doldecomp:masterfrom
g-guthrie:agent/fix-item-throw-argument

Conversation

@g-guthrie

Copy link
Copy Markdown
Contributor

What changed

  • Add the retail fifth integer argument to Item_8026AD20's declaration and definition.
  • Pass 1 from the forward-throw path and 0 from the backward-throw path in ftCo_80095EFC.

Why

The retail ftCo_80095EFC call sites materialize r6 immediately before both Item_8026AD20 calls. The current four-argument prototype omitted those instructions even though the callee does not consume the value.

Impact

This restores both missing call-site instructions and improves the remaining unmatched function without changing Item_8026AD20's body behavior.

Validation

  • Exact MWCC GC/1.2.5n compile of ftCo_ItemThrow.c and item.c
  • Function scorer: removed two missing instructions from ftCo_80095EFC (penalty 1410 to 1210)
  • python3 tools/check/main.py --fix --quiet
  • clang-format 22.1.0 --dry-run --Werror
  • git diff --check

@decomp-dev

decomp-dev Bot commented Aug 14, 2026

Copy link
Copy Markdown

Report for GALE01 (63e4e8a - 0c8bc7a)

📈 1 improvement in an unmatched item
Unit Item Bytes Before After
main/melee/ft/chara/ftCommon/ftCo_ItemThrow ftCo_80095EFC +19 90.02% 93.53%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant