Improve hsd_803B51C8 matching - #3083
Closed
g-guthrie wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Superseded by #3077, which improves the same function further (+425 bytes vs +402 bytes in the decomp.dev report). Keeping the stronger single contribution open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
hsd_803B51C8used genericmemcpycalls and repeatedly loaded the quantization scale inside three unrolled loops. Those source shapes differed substantially from the original compiler output.The aggregate assignments reproduce the target's paired loads/stores and counted AC-table loops, while the cached scale reproduces the target's single load before each unrolled division block.
Matching improvement
Validation
pre-commit run --files src/sysdolphin/baselib/hsd_3B34.cpython3 tools/check/main.py --quiet src/sysdolphin/baselib/hsd_3B34.cgit diff --checkhsd_803B51C8