Improve particle command interpreter matching - #3080
Draft
g-guthrie wants to merge 19 commits into
Draft
Conversation
added 11 commits
August 14, 2026 12:37
g-guthrie
force-pushed
the
agent/improve-particle-8039930c
branch
from
August 14, 2026 17:37
32407cd to
a0be742
Compare
added 8 commits
August 14, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
hsd_8039930Cis a 15,264-byte particle command interpreter and one of the largest unmatched functions in the project. The remaining differences are primarily expression ordering, pointer-update shapes, constant lifetimes, and register allocation rather than behavioral gaps.These source-equivalent changes preserve particle behavior while moving the generated PowerPC code closer to the original. The local exact-compiler comparison improves from 93.83255% on the base revision to 96.82888%. The current generated function is 15,260 bytes, four bytes short of the target, while the candidate
.sdata2section matches the target 96-byte size. Authoritative PR CI reports 492 additional matched bytes and improveshsd_8039930Cfrom 94.44% to 97.67%.Validation
clang-format --dry-run --Werror src/sysdolphin/baselib/particle.cpython3 tools/check/main.py --quiet src/sysdolphin/baselib/particle.cgit diff --check origin/master...HEADThe full local Ninja build requires
orig/GALE01/sys/main.dol, which is not present in this checkout. The authoritative link, test, and decomp.dev results are expected from the PR checks.