Output data cleaner#12496
Open
nhduongvn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
not-tested
Description
Summary
Implements block-by-block cleanup of
wma_prodRucio replication rules for output data during the disk/tape transfer phase, releasing origin-T2 disk space as individual blocks complete rather than waiting for all transfers across the entire workflow to finish.Background:
wma_prodcontainer-level rules are disabled. Block-level rules (one per output block) are used instead, with a configurable number of replicas (blockRuleParams, currently set tocopies=1to pin the origin-T2 replica only — previou slycopies=2). Because there is no container rule, a significant amount of data can be transferred before any individual disk rule reaches OK state — making it necessary to track disk rule completion (TransferDisk) separately from tape rule completion (TransferTape) before allowing full cleanup to proceed.Changes
MSRuleCleaner.pycleanOutputBlockRules()— runs during partial transfer phase, expires awma_prodblock rule (lifetime=0) as soon as all files in that block have OK locks in allwmcore_outputrules (disk + tape intersection)_getOkFilesFromRule()helper returning the set of fully-replicated files for a Rucio rule_dispatchWflowcondition to trigger partial cleanup when either disk or tape transfers are still pendingMSRuleCleanerWflow.pyTransferDiskflag to track when allwmcore_outputdisk rules are in OK state. The container level ofwma_prodis disabled so there might be significant data transfer before the disk rule is OK. Therefore, we need to track this separately — otherwisecleanuplineswould proceed before transfers are complete.WMAgentConfig.py/RucioInjectorPoller.pyblockRuleParams = {"copies": 1}(configurable) — block rules now pin the origin-T2 replica only, no second site replicaRucio.pylistReplicaLocks()to retrieve per-file lock states for a given rule IDMSRuleCleanert.pyTransferDiskandWmcOutputRulesMapfieldscleanOutputBlockRulesIs it backward compatible (if not, which system it affects?)
YES