Skip to content

python 3.12 - necessary requirements.txt upgrades#12336

Merged
mapellidario merged 1 commit into
dmwm:masterfrom
mapellidario:20250418_py312_requirements
May 9, 2025
Merged

python 3.12 - necessary requirements.txt upgrades#12336
mapellidario merged 1 commit into
dmwm:masterfrom
mapellidario:20250418_py312_requirements

Conversation

@mapellidario

Copy link
Copy Markdown
Member

Related to #12208

Status

tested, works on a manual docker image build with python 3.12 on debian 12

Description

some of the versions of the packages that we depend on are not compatible with recent python 3.12. We need to upgrade their versions if we want to be able to run with python 3.12

please, notice how the cheetah3 project changed the name of the package on pypi from `` to CT3 [1]

Is it backward compatible (if not, which system it affects?)

yes, these versions are compatible with python 3.8

Related PRs

none

External dependencies / deployment changes

yes, this PR changes the versions of some packages that we depend on


[1]

@dmwm-bot

Copy link
Copy Markdown

Jenkins results:

  • Python3 Unit tests: succeeded
    • 1 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/585/artifact/artifacts/PullRequestReport.html

@todor-ivanov todor-ivanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@amaltaro amaltaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dario, it looks good to me as well.

@mapellidario mapellidario force-pushed the 20250418_py312_requirements branch from b5b7755 to 6d73ebe Compare May 8, 2025 15:01
@mapellidario

Copy link
Copy Markdown
Member Author

I rebased this branch onto master, i doubled check again and it should be safe to merge. things are expected to work with python3.8 and python3.12. This is ready to be merged, but i do not want to do it without antoher double check from the team :)

@dmwm-bot

dmwm-bot commented May 8, 2025

Copy link
Copy Markdown

Jenkins results:

  • Python3 Unit tests: succeeded
    • 3 changes in unstable tests
  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/675/artifact/artifacts/PullRequestReport.html

@mapellidario

Copy link
Copy Markdown
Member Author

since we all agree and since this is required for dmwm/CMSKubernetes#1604, i am merging this PR

@mapellidario mapellidario merged commit 1a108ab into dmwm:master May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants