wmcore-dev: Updates image to use Python 3.12#1628
Merged
Merged
Conversation
Contributor
Author
|
If this is merged: dmwm/WMCore#12413, I can remove |
This was referenced Jul 15, 2025
Merged
Contributor
Author
|
This image doesn't use the cmsweb-alma9-base image anymore, so PR #1631 can be disregarded. |
Contributor
@d-ylee is it for user development or Jenkins (or both)? Is it ready for a review, or are you still working on this PR? |
Contributor
Author
|
This image doesn't use the cmsweb-alma9-base image anymore, so PR #1631 can be disregarded. |
amaltaro
requested changes
Jul 29, 2025
amaltaro
left a comment
amaltaro
left a comment
Contributor
There was a problem hiding this comment.
@d-ylee this looks good in general, however I have several questions/comments to make, which are likely going to trigger updates to this PR.
- Can you please update the PR description clarifying why all of the python scripts have been removed from this build?
- what is the difference between Dockerfile and Dockerfile.dev? If we need both, can you please clarify them in the README file?
- I am not sure I understand the usage of the
IMAGE_VERSIONargument. Is it supposed to be the same as the label used in CERN Registry? Perhaps add a comment line above that ARG statement? - I think we could also add instructions to the README on how to use the Makefile
d-ylee
force-pushed
the
fix-12383_update-to-python3.12
branch
2 times, most recently
from
fbd6dcd to
ffe64f9
Compare
Remove nose, install pynose Ensure correct ownership of uv install directory
Updated Makefile for push and tagging based on WMCORE tags
d-ylee
force-pushed
the
fix-12383_update-to-python3.12
branch
from
ffe64f9 to
5deb0f9
Compare
amaltaro
approved these changes
Aug 1, 2025
amaltaro
left a comment
amaltaro
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much, Dennis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fixing dmwm/WMCore#12383
Changes
/home/cmsbldDepends on
#1604
Depends on the cmsweb-alma9-base and gfal2 images in this PR.