Skip to content

[spec/statement] Clarify foreach restrictions#22917

Open
ntrel wants to merge 1 commit intodlang:masterfrom
ntrel:foreach-rest
Open

[spec/statement] Clarify foreach restrictions#22917
ntrel wants to merge 1 commit intodlang:masterfrom
ntrel:foreach-rest

Conversation

@ntrel
Copy link
Copy Markdown
Contributor

@ntrel ntrel commented Apr 13, 2026

Fixes #22910.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22917"

Comment thread spec/statement.dd
while `foreach` is iterating over the elements.
)

$(UNDEFINED_BEHAVIOR If one of those operations occurs and it is `@system`.)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 'it' refer to the operation or the enclosing function? The latter makes more sense to me, but the wording implies the former.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkorpel I think if the operation is allowed in @safe code, it should be implementation-defined iff it happens in @system code which doesn't do anything unsafe (or it does something unsafe that is unrelated to the operation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Statements] Foreach Restrictions wording is too vague

3 participants