Skip to content

Thread class is split into a version(CoreDdoc) and other#22805

Open
denizzzka wants to merge 1 commit intodlang:masterfrom
denizzzka:osthread_coreddoc_class
Open

Thread class is split into a version(CoreDdoc) and other#22805
denizzzka wants to merge 1 commit intodlang:masterfrom
denizzzka:osthread_coreddoc_class

Conversation

@denizzzka
Copy link
Copy Markdown
Contributor

@denizzzka denizzzka commented Mar 24, 2026

  • Thread class is split into a version(CoreDdoc) and other
  • Removed outdated comments like:
///////////////////////////
/// Like this
//////////////////////////

(It was previously discussed that this is obsolete and can be removed.)

The point of this PR is to be able to further separate Thread class implementations for Posix, Windows and maybe other OSes

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22805"

@denizzzka denizzzka force-pushed the osthread_coreddoc_class branch from 920fb51 to aea4fa0 Compare March 24, 2026 12:13
@denizzzka denizzzka marked this pull request as ready for review March 24, 2026 12:15
@thewilsonator
Copy link
Copy Markdown
Contributor

(It was previously discussed that this is obsolete and can be removed.)

Where?

@denizzzka
Copy link
Copy Markdown
Contributor Author

denizzzka commented Mar 25, 2026

@thewilsonator I think it was before 2022 and I can't find it now.
I scrupulously dragged-and-dropped these comments when I was doing some manipulations with splitting large files into smaller ones (also around the threads support), and someone commented that there was no need for this; they were planning to get rid of them anyway.

Here it also looks logical, because inside of CoreDdoc version of Thread isn't need to describe such "blocks".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants