Adds spec for issue with memoization and dynamic methods#36
Open
alxberardi wants to merge 1 commit intodkubb:masterfrom
Open
Adds spec for issue with memoization and dynamic methods#36alxberardi wants to merge 1 commit intodkubb:masterfrom
alxberardi wants to merge 1 commit intodkubb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dkubb ,
I think I might have found an issue with memoization.
Apparently, when memoizing a method which initialises objects that define methods dynamically, the dynamic methods on the object are no longer public.
Please see the spec I added to replicate the problem.
When running the spec, this is the output I get (stripped of non relevant lines):
I apologise for not having provided a solution, unfortunately I do not have the time to investigate the issue any further at this moment, but I hope that the spec I provided might help you investigate the issue for future releases.