Remove core2 dependency#132
Merged
Merged
Conversation
Collaborator
|
thanks! 🫡 what a mess |
Contributor
Author
|
Do you want this PR to patch core2 to the pre-yank version, so that we're not stuck waiting for a new libflate release? |
Collaborator
|
thanks! i don't think we need that at the moment, we don't have a product to ship per se, but we should hold onto it in case this runs more than a day or two. that's good to have |
core2 has been deprecated in the most fun of ways. All releases have been yanked, meaning that if you don't have a lockfile checked into git, you're SOL and can't build.
wojciech-graj
changed the title
Contributor
Author
|
We're successfully building again! |
Collaborator
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core2 has been deprecated in the most fun of ways. All releases have been yanked, meaning that if you don't have a lockfile checked into git, you're SOL and can't build.