Skip to content

[DAP-17] Rename VDAF "Preparation" to "Verification"#4594

Open
jcjones wants to merge 1 commit into
mainfrom
jcj/dap-17-prepare-verify-rename
Open

[DAP-17] Rename VDAF "Preparation" to "Verification"#4594
jcjones wants to merge 1 commit into
mainfrom
jcj/dap-17-prepare-verify-rename

Conversation

@jcjones
Copy link
Copy Markdown
Contributor

@jcjones jcjones commented May 12, 2026

Warning

This renames all metrics, too, so we'll need to revisit all the dashboards. I believe that is the correct move here.

  • Renames the database columns, but we're assuming we're starting from clean anyway for the DAP-16 changes.
  • The public AggregationJobResp.prepare_resps rename to verify_resps is a public API break for the external Rust consumers of janus_messages.

> [!warning] This renames all metrics, too, so we'll need to revisit all the dashboards. I
> believe that is the correct move here.

- The public AggregationJobResp.prepare_resps rename to verify_resps is a public API break
  for the external Rust consumers of janus_messages.
@tgeoghegan
Copy link
Copy Markdown
Contributor

You'll want to throw label allow-changed-migrations on this and re-run CI (which happens on its own if you push new commits). Otherwise this is still a draft so I will wait before I review.

@jcjones jcjones added allow-changed-migrations Override the ci-migrations check to allow migrations that have changed. breaking draft-ietf-ppm-dap-17+ Stuff for implementing draft-ietf-ppm-dap-17 and beyond labels May 13, 2026
@jcjones jcjones added this to the draft-ietf-ppm-dap-17 milestone May 13, 2026
@jcjones jcjones marked this pull request as ready for review May 14, 2026 22:52
@jcjones jcjones requested a review from a team as a code owner May 14, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow-changed-migrations Override the ci-migrations check to allow migrations that have changed. breaking draft-ietf-ppm-dap-17+ Stuff for implementing draft-ietf-ppm-dap-17 and beyond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants