Skip to content

chore(feed): delete the dead _LoadingIndicator #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hm21 merged 1 commit into from
Jul 31, 2026
Merged

chore(feed): delete the dead _LoadingIndicator #6559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions mobile/lib/screens/feed/pooled_fullscreen_video_feed_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,47 +964,6 @@ class _FullscreenFeedContentState extends ConsumerState<FullscreenFeedContent>
}
}

class _LoadingIndicator extends StatefulWidget {
const _LoadingIndicator();

@override
State<_LoadingIndicator> createState() => _LoadingIndicatorState();
}

class _LoadingIndicatorState extends State<_LoadingIndicator> {
// Delay before the indicator becomes visible. Suppresses sub-threshold
// flashes that occur during play/pause and loop-enforcement seeks without
// hiding the indicator during genuine long loads.
static const _delay = Duration(milliseconds: 100);
static const _fadeDuration = Duration(milliseconds: 150);

bool _visible = false;
Timer? _timer;

@override
void initState() {
super.initState();
_timer = Timer(_delay, () {
if (mounted) setState(() => _visible = true);
});
}

@override
void dispose() {
_timer?.cancel();
super.dispose();
}

@override
Widget build(BuildContext context) {
return AnimatedOpacity(
duration: _fadeDuration,
opacity: _visible ? 1.0 : 0.0,
child: const Center(child: BrandedLoadingIndicator(size: 60)),
);
}
}

/// Wraps the fullscreen video feed in a [NavRoundedShell] when the
/// inline comment composer bar is on screen, so the bottom of the
/// video carries the same rounded-corner treatment as the home feed.
Expand Down
Loading