[codex] Fix RunDevServer SIGTERM orphaned GHCi#2616
Draft
mpscholten wants to merge 4 commits intocodex/pre-2607-masterfrom
Draft
[codex] Fix RunDevServer SIGTERM orphaned GHCi#2616mpscholten wants to merge 4 commits intocodex/pre-2607-masterfrom
mpscholten wants to merge 4 commits intocodex/pre-2607-masterfrom
Conversation
a11bd9a to
bb09296
Compare
Core Size & Compile Allocations Benchmark
HTTP Latency (GET /, 5000 reqs, 10 concurrent)
Top 10 modules (this PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunDevServerSIGTERM orphaned-GHCi bugSIGTERMhandler inRunDevServerWhy
This keeps the new regression check in-tree while fixing the underlying bug, so the same CI path that fails on the regression-only branch should pass here.
User Impact
Stopping the dev server during the GHCi load/compile phase should no longer leave a stray
ghciprocess behind holding:8000.Root Cause
RunDevServerreceivedSIGTERM, but the active GHCi child was started in its own process group. During the load phase, exiting the parent process was not enough to reliably kill that detached child.Validation
bash -n integration-test/run-devserver-sigterm-check.shrun-devserver-sigtermflake check and pass with the fix included