[codex] Add RunDevServer SIGTERM regression check#2615
Draft
mpscholten wants to merge 4 commits intocodex/pre-2607-masterfrom
Draft
[codex] Add RunDevServer SIGTERM regression check#2615mpscholten wants to merge 4 commits intocodex/pre-2607-masterfrom
mpscholten wants to merge 4 commits intocodex/pre-2607-masterfrom
Conversation
Core Size & Compile Allocations Benchmark
HTTP Latency (GET /, 5000 reqs, 10 concurrent)
Top 10 modules (this PR)
|
10ee266 to
dd67999
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunDevServerintegration-testapp as a real fixture with a boilerplate-style.ghciRunDevServermid-load and assert the childghciprocess exitsWhy
This is intended to reproduce the orphaned-GHCi bug from #2606 in CI. On
master,RunDevServerstill exits without reliably terminating the detachedghcichild during the compile window, so this PR is expected to fail until the fix is applied.User Impact
If this check fails, it means a development restart can leave a stray
ghciprocess behind holding the app port afterRunDevServerreceivesSIGTERM.Root Cause
RunDevServerstartsghciin its own process group. During the initial load, terminating the parent process alone is not enough to guarantee the child process group dies too.Validation
bash -n integration-test/run-devserver-sigterm-check.shrun-devserver-sigtermflake check and fail on currentmaster