Skip to content

Fix datetime-local timezone shift by replacing Flatpickr with native picker #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpscholten wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix datetime-local timezone shift by replacing Flatpickr with native picker #2581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 46 additions & 11 deletions ihp/data/static/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ document.addEventListener('DOMContentLoaded', function () {
initToggle();
initTime();
initDatePicker();
initDateTimeLocal();
initFileUploadPreview();

document.dispatchEvent(ihpLoadEvent);
Expand All @@ -34,6 +35,7 @@ document.addEventListener('turbolinks:load', function () {
}, 1);

initDatePicker();
initDateTimeLocal();

document.dispatchEvent(ihpLoadEvent);
});
Expand Down Expand Up @@ -397,21 +399,54 @@ function initDatePicker() {
});
});

document.querySelectorAll("input[type='datetime-local']").forEach(el => {
// Append Z so Flatpickr knows the server value is UTC
if (el.value && !el.value.endsWith('Z')) {
el.value = el.value + 'Z';
}
flatpickr(el, {
...(el.dataset.enableTime ? {} : { enableTime: true }),
...(el.dataset.time_24hr ? {} : { time_24hr: true }),
...(el.dataset.dateFormat ? {} : { dateFormat: 'Z' }),
...(el.dataset.altFormat ? {} : { altFormat: 'd.m.y, H:i' }),
...(el.dataset.altInput ? {} : { altInput: true }),
}

// Converts server-rendered UTC values in datetime-local inputs to the user's
// local timezone for display, and converts back to UTC on form submit.
// This replaces Flatpickr for datetime-local inputs — the native browser
// picker is used instead.
function initDateTimeLocal() {
// Convert server-rendered UTC values to local time for display
document.querySelectorAll("input[type='datetime-local']").forEach(function(el) {
if (!el.value) return;
var utcDate = new Date(el.value + 'Z');
if (isNaN(utcDate.getTime())) return;
el.value = formatLocalDateTime(utcDate);
});

// On form submit, convert local values back to UTC before FormData reads them.
// Form-level listeners fire before IHP's document-level submit handler,
// so values are converted before submitForm() creates FormData.
document.querySelectorAll('form').forEach(function(form) {
if (form.dataset.datetimeLocalHandled) return;
form.dataset.datetimeLocalHandled = 'true';
form.addEventListener('submit', function() {
form.querySelectorAll("input[type='datetime-local']").forEach(function(el) {
if (!el.value) return;
var localDate = new Date(el.value);
if (isNaN(localDate.getTime())) return;
el.value = formatUTCDateTime(localDate);
});
});
});
}

function formatLocalDateTime(date) {
return date.getFullYear() + '-' +
String(date.getMonth() + 1).padStart(2, '0') + '-' +
String(date.getDate()).padStart(2, '0') + 'T' +
String(date.getHours()).padStart(2, '0') + ':' +
String(date.getMinutes()).padStart(2, '0');
}

function formatUTCDateTime(date) {
return date.getUTCFullYear() + '-' +
String(date.getUTCMonth() + 1).padStart(2, '0') + '-' +
String(date.getUTCDate()).padStart(2, '0') + 'T' +
String(date.getUTCHours()).padStart(2, '0') + ':' +
String(date.getUTCMinutes()).padStart(2, '0');
}

var locked = false;
window.transitionToNewPage = function (newHtml) {
if (locked) {
Expand Down