Making log window colorful#2197
Open
ZichaoNickFox wants to merge 2 commits intodigitallyinduced:masterfrom
Open
Making log window colorful#2197ZichaoNickFox wants to merge 2 commits intodigitallyinduced:masterfrom
ZichaoNickFox wants to merge 2 commits intodigitallyinduced:masterfrom
Conversation
Collaborator
|
shouldn't all those [37m…[0m in your screenshots be turned into span color's too then? |
Contributor
Author
|
Other So ihp/ihp-ide/IHP/IDE/Logs/View/Logs.hs Line 7 in b6c60a5 To solve the problem, we should not discard I will confirm if the converting discards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For making the log window easy to read or distinguishing log types. I added a functionality to give users the chance to print logs in color. Such as.
The call from users would like
Compiling
hsxwill discard\ESC. So I use fake\\ESCto keep\ESCto the frontend. Then, beforeansiUp.ansi_to_htmlconverts the string into HTML, I replace\\ESCback to\ESCin JavaScript.ansiUpwill insert<span>by\ESC[keywords, which is the principle of this implementation.type="module"of<script type="module" src={assetPath "/vendor/ansi-up.min.js"}></script>is a trade-off. I cannot figure out another method foransi-up, because it hasexporteven inansi-up.min.js. AI says it is aES6standard.