Delete ContractKeyNotVisible in the IDE ledger#22901
Conversation
dylant-da
left a comment
dylant-da
left a comment
There was a problem hiding this comment.
Tentatively approving of this on the assumption that you'll re-request a review if it turns out further changes need to be made when https://github.com/DACH-NY/canton/pull/32081#pullrequestreview-4120150214 is merged
carlpulley-da
added
the
no-release-notes
| repeated Party observers = 4; | ||
| } | ||
|
|
||
| message ContractKeyNotVisible { |
There was a problem hiding this comment.
@dylant-da FYI, changes to this file remove the relevant proto definitions from script_service.proto
| Empty script_mustfail_succeeded = 22; | ||
| string script_invalid_party_name = 23; | ||
| ContractKeyNotVisible script_contract_key_not_visible = 24; | ||
| Empty script_contract_key_not_visible = 24; |
There was a problem hiding this comment.
Looks good to me :)
| , label_ "Stakeholders:" | ||
| $ prettyParties scriptError_ContractKeyNotVisibleStakeholders | ||
| ] | ||
| ScriptErrorErrorScriptContractKeyNotVisible _ -> |
There was a problem hiding this comment.
As the proto message ContractKeyNotVisible is set to be empty, we still need this pretty print case. Here I've followed the pattern for other cases where messages are empty.
| Empty script_mustfail_succeeded = 22; | ||
| string script_invalid_party_name = 23; | ||
| ContractKeyNotVisible script_contract_key_not_visible = 24; | ||
| Empty script_contract_key_not_visible = 24; |
There was a problem hiding this comment.
reserved does not appear to work under a oneof scope
4 participants
Fixes https://github.com/DACH-NY/canton/issues/32006
When PR https://github.com/DACH-NY/canton/pull/32081 is merged, this PR will fix its breaking changes. Until then, this PR is expected to fail.