Refactor dedupBy to drop intermediary strict list with mapWithIndex.#22438
Open
yangzai wants to merge 1 commit intodigital-asset:mainfrom
Open
Refactor dedupBy to drop intermediary strict list with mapWithIndex.#22438yangzai wants to merge 1 commit intodigital-asset:mainfrom
yangzai wants to merge 1 commit intodigital-asset:mainfrom
Conversation
yangzai
commented
Nov 27, 2025
| let | ||
| indexed = zip xs [1..length xs] | ||
| comp x y = cmp (fst x) (fst y) | ||
| indexed = mapWithIndex (,) xs |
Contributor
Author
There was a problem hiding this comment.
New indices are off by 1 and swapped, but these are inconsequential.
yangzai
force-pushed
the
hy-dedup-by-refactor
branch
from
0b63244 to
6f85264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #20591.