Improve parser error messages for templates#22400
Open
dpny518 wants to merge 2 commits intodigital-asset:mainfrom
Open
Improve parser error messages for templates#22400dpny518 wants to merge 2 commits intodigital-asset:mainfrom
dpny518 wants to merge 2 commits intodigital-asset:mainfrom
Conversation
This commit enhances parse error diagnostics to provide more helpful, context-specific error messages for common Daml template issues. Fixes digital-asset#22354: When 'choice' is badly indented, the error now includes a hint about proper indentation with an example. Addresses digital-asset#22361: For generic parse errors that commonly occur with missing key type signatures, the error now includes hints about common template parsing issues, including the requirement that 'key' needs an explicit type signature. The implementation adds a diagnostic post-processing layer in sendFileDiagnostics that pattern-matches specific error messages and enhances them with targeted hints, similar to how LF conversion errors are handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enhances parse error diagnostics to provide more helpful, context-specific error messages for common Daml template issues.
Fixes #22354: When 'choice' is badly indented, the error now includes a hint about proper indentation with an example.
Addresses #22361: For generic parse errors that commonly occur with missing key type signatures, the error now includes hints about common template parsing issues, including the requirement that 'key' needs an explicit type signature.
The implementation adds a diagnostic post-processing layer in sendFileDiagnostics that pattern-matches specific error messages and enhances them with targeted hints, similar to how LF conversion errors are handled.