Skip to content

fix: Don't use getAddress in start/stop of local-discovery #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RangerMauve merged 4 commits into from
Oct 14, 2025
Merged

fix: Don't use getAddress in start/stop of local-discovery #1136

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a8e882
fix: Don't use getAddress in start/stop of local-discovery
Oct 8, 2025
e37f037
chore: move discovery port setting from #start() to start()
Oct 13, 2025
778afd7
Revert "chore: move discovery port setting from #start() to start()"
Oct 14, 2025
d6cf428
Merge branch 'main' into feat/local-discovery-simplify-port
RangerMauve Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/discovery/local-discovery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ export class LocalDiscovery extends TypedEmitter {
/** @returns {Promise<{ name: string, port: number }>} */
async start() {
await this.#sm.start()
return { name: this.#name, port: getAddress(this.#server).port }
const port = this.#port
return { name: this.#name, port }
}

/** @returns {Promise<void>} */
Expand Down Expand Up @@ -288,7 +289,7 @@ export class LocalDiscovery extends TypedEmitter {
*/
async #stop({ force = false, timeout = 0 } = {}) {
this.#log('stopping')
const { port } = getAddress(this.#server)
const port = this.#port
this.#server.close()
const closePromise = once(this.#server, 'close')

Expand Down